So I'm reading commit dc215b143 and I'm uncertain how much we want to involve 
_legacy_detect_multipath in future facing code.  It seems to me that the cases 
that support multipath have multipathd present, and cases that don't support it 
(desktop) don't have it.

I would like you to consider that detect_multipath() should return None both 
for the `multipath.multipath_supported() == False` case along with the 
`multipath.multipath_supported() == True` case where we aren't detecting 
multipath.

_legacy_detect_multipath seems to have history in cases predating proper 
multipath awareness.

I haven't pondered the suggested changes to _legacy very much as I'm 
considering the possibility that you should delete _legacy_detect_multipath 
outright.
-- 
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/481223
Your team curtin developers is subscribed to branch curtin:master.


-- 
Mailing list: https://launchpad.net/~curtin-dev
Post to     : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to