yasithdev opened a new pull request, #500: URL: https://github.com/apache/airavata/pull/500
This pull request introduces several updates to the `airavata-python-sdk` project, focusing on improving code maintainability, adding type hints for better type safety, and updating the `.gitignore` file to exclude additional files and directories. The most significant changes include the addition of type annotations to the `CredentialStoreService` API, the upgrade of the Thrift compiler version, and the inclusion of new entries in the `.gitignore` file. ### Type Annotations and API Improvements * Added type annotations to all methods in `CredentialStoreService` to enhance type safety and clarity. This includes specifying parameter types and return types for methods such as `getCredentialSummary`, `addSSHCredential`, and `getAllCredentialSummaries`. [[1]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L23-R27) [[2]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L53-R73) [[3]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L96-R100) [[4]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L146-R150) * Updated the `CredentialStoreService` client methods to include type annotations in their send/receive functions for consistency. [[1]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L156-R160) [[2]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L203-R207) [[3]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L257-R261) ### Thrift Compiler Upgrade * Upgraded the Thrift compiler version from `0.18.1` to `0.21.0` across multiple files, enabling support for new features like `py:enum` and `type_hints`. [[1]](diffhunk://#diff-7a786180bba6175976ca8ea8ab71d1f9f2d8f45409d41201edf66330a2de863aL3-R7) [[2]](diffhunk://#diff-1ee4799a40d609047964770d54599b78dd6d20a5352f2abbc88e9c4e6ba2efe2L2-R15) [[3]](diffhunk://#diff-09c6e1f29003ae954c581cf704303e980f8a87352db6a1f85661ff48dee89a01L3-R7) [[4]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L2-R15) ### `.gitignore` Enhancements * Expanded the `.gitignore` file to exclude additional files and directories, including `__pycache__/`, `.DS_Store`, `.ipynb_checkpoints`, and temporary result files like `results*/`. ### Typing Improvements * Introduced `TYPE_CHECKING` imports in several modules to conditionally import types, reducing runtime overhead while maintaining type safety during development. [[1]](diffhunk://#diff-d537bfb818ce09c0e7dec55c712ea464ebf85be7f9933ed9d680c1662e1f1c47R1-R4) [[2]](diffhunk://#diff-eacb8b57fe6492770c5282eb7089a115a8c35351179497d329dcd98812bc5e7dR2-R6) [[3]](diffhunk://#diff-1a7f6530ce7a26cc998f9f78abea360e8c347727c89dd429f83539f296b016afR1-R4) ### Additional Python Features * Added `from __future__ import annotations` in relevant files to enable postponed evaluation of type annotations, improving compatibility with Python 3.7+. [[1]](diffhunk://#diff-1ee4799a40d609047964770d54599b78dd6d20a5352f2abbc88e9c4e6ba2efe2L2-R15) [[2]](diffhunk://#diff-8c784d905c7c4f3b536771909ec2c3212ec0bb6066133ba2df237441f8d380a9L2-R15) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
