yasithdev opened a new pull request, #639: URL: https://github.com/apache/airavata/pull/639
Two intra-class dedups in storage-service. In DataMovementRepository the four per-protocol getters (LOCAL/SCP/UNICORE/GridFTP) were identical except for the mapper, and the four adders except for the id prefix and mapper; they now delegate to two private helpers — getMovement(id, mapper) and addMovement(entity) — with the per-protocol toBuilder().setDataMovementInterfaceId(getID(PREFIX)) injection kept in each typed wrapper, the asymmetric update* methods left untouched, and null-on-missing semantics preserved. In DataStagingTask the structurally identical getInputStorageAdaptor/getOutputStorageAdaptor now delegate to a single direction-parameterized helper, which along the way fixes the output method's log line that mislabeled the resource as 'input'. Behavior-preserving; the full reactor builds green and storage-service tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
