On Wed, Nov 30, 2005 at 07:24:51PM +0000, Maxim Sobolev wrote: +> sobomax 2005-11-30 19:24:51 UTC +> +> FreeBSD src repository +> +> Modified files: +> sys/geom/mirror g_mirror.c +> sys/geom/vinum geom_vinum_drive.c +> sys/geom/label g_label_ufs.c g_label_iso9660.c +> g_label_msdosfs.c +> sys/geom/raid3 g_raid3.c +> sys/geom/uzip g_uzip.c +> sys/geom/eli g_eli.c +> sys/geom geom_aes.c geom_apple.c geom_bsd.c +> geom_fox.c geom_gpt.c geom_mbr.c +> geom_pc98.c geom_sunlabel.c +> geom_vol_ffs.c +> Log: +> Check for g_read_data(9) errors properly: +> +> o The only indication of error condition is NULL value returned by +> the function; +> +> o value pointed to by error argument is undefined in the case when +> operation completes successfully.
If you decided to clean this up, please make it a complete clean-up, so noone has to clean up after you:) The thing I'm talking about is that when you don't plan to use error value, you can just pass NULL as the last argument for g_read_data(9). There are probably few places now where 'error' variable is unused. -- Pawel Jakub Dawidek http://www.wheel.pl [EMAIL PROTECTED] http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am!
pgpOV53lqKxTj.pgp
Description: PGP signature
