On Wed, Dec 21, 2005 at 12:32:48AM -0800, Doug Barton wrote:
> Ruslan Ermilov wrote:
> >On Tue, Dec 20, 2005 at 08:56:21PM +0000, Doug Barton wrote:
> >>dougb       2005-12-20 20:56:21 UTC
> >>
> >>  FreeBSD src repository
> >>
> >>  Modified files:        (Branch: RELENG_6)
> >>    etc/rc.d             Makefile 
> >>  Log:
> >>  MFC 1.56, make install of sshd conditional on NO_OPENSSH
> >>  
> >>  Revision  Changes    Path
> >>  1.53.2.4  +6 -1      src/etc/rc.d/Makefile
> >>
> >The full condition, to match the sources, would be:
> >
> >.if !defined(NO_CRYPT) && !defined(NO_OPENSSL) && !defined(NO_OPENSSH)
> >
> >That's how we get to compile secure/usr.sbin/sshd/.
> 
> Well, I wondered about that, but I didn't make the original change, so I 
> just MFC'ed what was there. If you want to update the Makefile in HEAD I've 
> no objection, or if you think it's really important, I'll be glad to do it 
> as well.
> 
Please do it while you're at it.

> Personally, while I remember the support problems that not having all those 
> tests caused back in the day, I always thought that it was providing too 
> big a crutch. However, that's just grousing, and I've no objection to 
> updating rc.d/Makefile if you think we need to.
> 
Well, if the installation is conditional, the condition should be
correct.  Otherwise, it should be made unconditional.  :-)


Cheers,
-- 
Ruslan Ermilov
[EMAIL PROTECTED]
FreeBSD committer

Attachment: pgp8H9IlUCZpy.pgp
Description: PGP signature

Reply via email to