On Mar 7, 2008, at 5:01 AM, John Baldwin wrote:
On Thursday 06 March 2008 12:24:28 pm Marcel Moolenaar wrote:
marcel 2008-03-06 17:24:28 UTC
FreeBSD src repository
Modified files:
sys/sys pcpu.h
Log:
Move the PCPU_MD_FIELDS last in struct pcpu. While this header is
private to the kernel, some ports define _KERNEL and include this
header. While arguably this is wrong, it's also reality. By having
the MD fields last, architectures that have CPU-specific variations
of PCPU_MD_FIELDS will at least have the MI fields at a constant
offset. Of course, having all MI fields first helps kernel
debugging
as well, so this is not a change without some benefits to us.
This change does not result in an ABI breakage, because this header
is not part of the ABI. Recompilation of lsof is required though :-)
It actually started out being the last "field" in the structure but
some new
fields were incorrectly added after it rather than before it. It
might
warrant a comment to prevent similar regressions in the future.
--
John Baldwin
--
Marcel Moolenaar
[EMAIL PROTECTED]
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
