On Sat, 8 Mar 2008, Bjoern A. Zeeb wrote:
bz 2008-03-08 18:34:17 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6)
sys/netipsec key.c
Log:
MFC rev. 1.25
Add a missing return so that we drop out in case of an error and
do not continue with a NULL pointer. [1]
While here change the return of the error handling code path above.
I cannot see why we should always return 0 there. Neither does KAME
nor do we in here for the similar check in all the other functions.
Found with: Coverity Prevent(tm) [1]
CID: 2521
Revision Changes Path
1.20.2.3 +2 -3 src/sys/netipsec/key.c
The problem (which was a missing MFC) was
Reported by: Matthew Grooms mgrooms shrew.net
PR: 121140
--
Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
Software is harder than hardware so better get it right the first time.
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
