On Tue, Mar 18, 2008 at 07:38:55PM +0300, Stanislav Sedov wrote:
> On Tue, 18 Mar 2008 01:00:26 +0000 (UTC)
> Pietro Cerutti <[EMAIL PROTECTED]> mentioned:
> 
> > gahr        2008-03-18 01:00:26 UTC
> > 
> >   FreeBSD ports repository
> > 
> >   Modified files:
> >     java/eclipseme       Makefile distinfo pkg-plist 
> >   Log:
> >   - Update to 0.4.6
> >   
> >   Approved by:    miwi (mentor)
> >   
> >   Revision  Changes    Path
> >   1.6       +5 -8      ports/java/eclipseme/Makefile
> > http://cvsweb.FreeBSD.org/ports/java/eclipseme/Makefile.diff?r1=1.5&r2=1.6
> > | --- ports/java/eclipseme/Makefile 2007/07/16 08:58:28     1.5
> > | +++ ports/java/eclipseme/Makefile 2008/03/18 01:00:25     1.6
> > | @@ -2,15 +2,13 @@
> > |  # Date created:                          July 22, 2004
> > |  # Whom:                                  [EMAIL PROTECTED]
> > |  #
> > | -# $FreeBSD: 
> > /usr/local/www/cvsroot/FreeBSD/ports/java/eclipseme/Makefile,v 1.5 
> > 2007/07/16 08:58:28 pav Exp $
> > | +# $FreeBSD: 
> > /usr/local/www/cvsroot/FreeBSD/ports/java/eclipseme/Makefile,v 1.6 
> > 2008/03/18 01:00:25 gahr Exp $
> > |  #
> > |  
> > |  PORTNAME=        eclipseme
> > | -PORTVERSION=     0.4.5
> > | -PORTREVISION=    3
> > | +PORTVERSION=     0.4.6
> > |  CATEGORIES=      java devel
> > | -MASTER_SITES=    ${MASTER_SITE_SOURCEFORGE}
> > | -MASTER_SITE_SUBDIR=      ${PORTNAME}
> > | +MASTER_SITES=    SF
> > |  DISTNAME=        ${PORTNAME}-${PORTVERSION}
> > |  DIST_SUBDIR=     eclipse
> > |  
> > | @@ -31,11 +29,10 @@ RUN_DEPENDS+= ${LOCALBASE}/share/proguar
> > |  .endif
> > |  
> > |  do-install:
> > | -         @${CP} -r ${WRKSRC}/${PORTNAME}_${PORTVERSION} 
> > ${PREFIX}/eclipse/plugins/
> > | + @${MKDIR} ${PREFIX}/eclipse/plugins
> > | + @${CP} -r ${WRKSRC}/${PORTNAME}_${PORTVERSION} 
> > ${PREFIX}/eclipse/plugins/
> 
> Wouldn't it be better to use COPYTREE_SHARE for that? This way it'll set 
> correct
> permissions on files.

Not to mention that -R should've probably be used instead or -r, and we
generally try not to mute installation of files/links (as opposed to
dirs).

./danfe
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to