On Thu, 27 Mar 2008, John Birrell wrote:

jb          2008-03-27 05:03:26 UTC

 FreeBSD src repository

 Modified files:
   sys/amd64/include    param.h
   sys/arm/include      param.h
   sys/i386/include     param.h
   sys/ia64/include     param.h
   sys/powerpc/include  param.h
   sys/sparc64/include  param.h
   sys/sun4v/include    param.h
 Log:
 When building a kernel module, define MAXCPU the same as SMP so
 that modules work with and without SMP.

Hmm. I think this probably is the right thing, but we'll need to be very careful to watch for people defining foo[MAXCPU] in globally visible data structures in the kernel in such a way that entries for the non-current CPU are referenced by any modules. A casual glance suggests that, right now, this is not generally an issue, but something to watch out for, since we do use MAXCPU to size a number of kernel data structures.

Robert N M Watson
Computer Laboratory
University of Cambridge
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to