On Thu, 17 Apr 2008, Pawel Jakub Dawidek wrote:

pjd         2008-04-17 19:19:40 UTC

 FreeBSD src repository

 Modified files:
   sys/kern             kern_linker.c
 Log:
 Allow linker_search_symbol_name() to be called with KLD lock held.
 The linker_search_symbol_name() function is used by stack_print()
 and stack_print() can be called from kernel module unload method.

I'm not sure I'm entirely comfortable with this locking change; conditional locking of this type is something we've generally tried to eliminate. If this is for debugging code used in locking sensitive contexts, it is probably preferable to use one of the _ddb variations on the stack(9) routines, which bypass locking. Or, in this case, it simply uses the locks that are already, conveniently, held.

Robert N M Watson
Computer Laboratory
University of Cambridge
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to