David O'Brien wrote:
On Wed, Apr 30, 2008 at 09:59:05AM -0700, Sam Leffler wrote:
David O'Brien wrote:
On Tue, Apr 29, 2008 at 09:35:24PM +0000, Sam Leffler wrote:
. exclude Log:
add iwn firmware
Hi Sam,
I notice we keep excluding $FreeBSD$ from uuencoded firmware files.
At least looking at sys/contrib/dev/iwn/iwlwifi-4965-4.44.17.fw.uu,
which has a Copyright notice at the top, I think the use of this file
would tolerate a $FreeBSD$ on the first line.
Would you mind if I fixed this?
I copied previous practice in excluding the entire directory.
I think "the previous practice" mostly comes from the wireless firmware
where the folks committing it may not have realized that "$FreeBSD$" will
be nicely ignored by uudecode.
I was involved with placing the other Intel firmware in sys/contrib.
The issue
isn't whether it's possible to insert a keyword but rather whether it's a
good idea to alter files (like the LICENSE files) that come directly from
"the vendor" under limited terms.
# $FreeBSD: src/sys/contrib/dev/ral/rt2860.fw.uu,v 1.1 2008/04/20 20:35:35 sam
Exp $
(and the other *.uu's there) are examples where we've done it. And I
think its fine.
Note, if these come straight from a vendor, why aren't they being vendor
imported?
If "these" refers to the ralink firmware images they do not come
straight from the vendor; I generated them from the rt2661_ucode.h file
I got from obsd CVS. The LICENSE file in that directory however
could/should be intact but I was lazy; I will correct that.
I'm not opposed to adding a keyword but I don't want to have to go back
through lawyers to get approval. If you want to do all the work be my
guest.
Sam
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
