On Sat, 21 Jan 2006, Stefan Farfeleder wrote:
On Sat, Jan 21, 2006 at 12:10:33PM +0000, Tom Rhodes wrote:trhodes 2006-01-21 12:10:33 UTC FreeBSD src repository Modified files: sys/nfsserver nfs_serv.c Log: Remove some dead code. Found with: Coverity Prevent(tm)Hm, are you sure this change is correct? Apparently Coverity thinks that dirp is always 0 at this point, yes? Looking at nfs_namei() I don't believe that. Also the comment above this is now stale and the code inside 'if (error)' not indented properly.
I was purposefully avoiding trying to investigate the NFS reports from Coverity as the NFS macro maze is very twisty, and the dead code reports are more likely logical errors preventing reaching code that shouldn't be dead than code that is actually no longer useful. I figured I would leave them for a quiet long weekend. Given the above, I suspect strongly my instinct was right. :-)
Robert N M Watson _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
