John Baldwin wrote:
On Saturday 29 October 2005 10:12:49 pm David Xu wrote:
davidxu 2005-10-30 02:12:49 UTC
FreeBSD src repository
Modified files:
sys/sys signal.h signalvar.h aio.h
sys/kern syscalls.master vfs_aio.c
Log:
Fix sigevent's POSIX incompatible problem by adding member fields
sigev_notify_function and sigev_notify_attributes. AIO syscalls
use sigevent, so they have to be adjusted.
Reviewed by: alc
I'm looking at doing 32-bit compat for AIO, and the __spare__ thing in 'struct
aiocb' strikes me as rather odd. For one, why not use 'struct osigevent
__spare__;' instead of the explicit sizeof()'s? The sizeof's make
assumptions about padding for example.
If you have patch, please commit it.
Secondly, since you bumped the
syscalls for the new structure, you didn't need the __spare__ hack at all.
I had put spare fields, I didn't know if people will need spare fields
in future
without breaking binary compatibility, so I just reused the old fields.
Regards,
David Xu
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
