Jun Kuriyama wrote: > kuriyama 2006-01-30 14:02:49 UTC > > FreeBSD ports repository > > Modified files: > comms/conserver-com Makefile distinfo pkg-plist > Added files: > comms/conserver-com/files conserver.sh.in > Removed files: > comms/conserver-com/files conserver.sh > Log: > - Upgrade to 8.1.13. > - Improve $USE_RC_SUBR usage.
Overall this looks good, thanks! One nit though, it is no longer necessary to include the FreeBSD KEYWORD, as rc.subr doesn't need it. On the other hand, since I believe that this port is responsible for starting a daemon, it should probably include 'REQUIRE: DAEMON', and the shutdown KEYWORD. I'd be happy to make those changes if they are appropriate, just let me know. Regards, Doug > PR: ports/91839 > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=91839 > Submitted by: Andrew Pantyukhin <[EMAIL PROTECTED]> > > Revision Changes Path > 1.30 +2 -11 ports/comms/conserver-com/Makefile > 1.20 +3 -3 ports/comms/conserver-com/distinfo > 1.3 +0 -22 ports/comms/conserver-com/files/conserver.sh (dead) > 1.1 +22 -0 ports/comms/conserver-com/files/conserver.sh.in (new) > 1.5 +0 -1 ports/comms/conserver-com/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/Makefile.diff?&r1=1.29&r2=1.30&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/distinfo.diff?&r1=1.19&r2=1.20&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/files/conserver.sh > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/files/conserver.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/pkg-plist.diff?&r1=1.4&r2=1.5&f=h > -- This .signature sanitized for your protection _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
