On Fri, 05 Jun 2009 18:35:11 +0200 Gabor Kovesdan <[email protected]> wrote:
> Doug Barton escribió: > > Gabor Pali wrote: > > > >> pgj 2009-06-05 11:59:16 UTC > >> > >> FreeBSD ports repository > >> > >> Modified files: > >> devel/hs-alex Makefile > >> Log: > >> - Respect custom PREFIX, LOCALBASE > >> - Bump port revision > >> > >> Reported by: QAT > >> Approved by: gabor (mentor) > >> > >> Revision Changes Path > >> 1.27 +7 -0 ports/devel/hs-alex/Makefile > >> > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/devel/hs-alex/Makefile.diff?&r1=1.26&r2=1.27&f=h > >> > >> > > > > I can't see any reason for a PORTREVISION bump here. Kudos for > > fixing this issue, but if we do bumps for every time nothing but > > this is fixed our users are going to be doing a lot of needless > > recompiles for no benefit. > > > As approver, I also thought about this but some people might use a > different PREFIX/LOCALBASE configuration constantly and in this case > a rebuild is necessary to get this port installed correctly. I don't > think using custom PREFIX/LOCALBASE is widespread but theoretically > it is possible that there are such people. The bump was not needed here since the port didn't build at all with custom LOCALBASE/PREFIX. Since it didn't build it couldn't have been installed or packaged, so no need to bump. In the general case I think we should bump PORTREVISION when fixing something, even for non-default configurations since there's no other way for a user to know to upgrade. Some disagree. -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> [email protected], PGP Key ID 057E9F8B493A297B
signature.asc
Description: PGP signature
