Wesley Shields wrote:
> wxs         2009-07-13 16:22:56 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net-mgmt/flowd       Makefile 
>   Added files:
>     net-mgmt/flowd/files flowd.in 
>   Log:
>   - Install RC script.
>   
>   PR:             ports/135949  
> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=135949
>   Submitted by:   Rashid N. Achilov <[email protected]>
>   Approved by:    maintainer timeout
>   
>   Revision  Changes    Path
>   1.14      +2 -0      ports/net-mgmt/flowd/Makefile
>   1.1       +30 -0     ports/net-mgmt/flowd/files/flowd.in (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/Makefile.diff?&r1=1.13&r2=1.14&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/files/flowd.in
> 
Overall this looks quite good, thanks! The only thing I would change
is to eliminate the empty _flags assignment, and include that in the
example comments at the top. You might also want to s/ipcad/flowd/. :)


hth,

Doug
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to