Doug Barton <[email protected]> writes: > Dag-Erling Smørgrav <[email protected]> writes: > > That's a lot of extra code for no perceivable benefit... > The if/else code is essentially the same as yours. Splitting out the > flags that are common between your two options makes the code more > readable. There is also the issue that code in rc.d scripts shouldn't > run unconditionally, but I don't regard that as critical in this case > since you're just setting variables. > > Ultimately it's up to you whether you want to accept the patches or > not. I think they're useful but I am not going to make a stink about it.
The *rest* of the patch is very useful. Thank you :) DES -- Dag-Erling Smørgrav - [email protected] _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[email protected]"
