On Sat, 24 Oct 2009 13:05:41 +0200 Beat Gaetzi <[email protected]> mentioned:
> Stanislav Sedov wrote: > > On Fri, 23 Oct 2009 14:29:50 +0000 (UTC) > > Beat Gaetzi <[email protected]> mentioned: > > \ > >> | # > >> | > >> | PORTNAME= virtualbox > >> | @@ -76,6 +76,14 @@ KMK_BUILDTYPE= release > >> | KMK_CONFIG= VBOX_LIBPATH_X11=${LOCALBASE} > >> VBOX_FREEBSD_SRC=${SRC_BASE}/sys > >> | KMK_FLAGS= > >> | > >> | +.if defined(WITHOUT_QT4) && !defined(WITHOUT_NLS) > >> | +BROKEN= NLS support requires QT4 frontend. Run 'make config' > >> again! > >> | +.endif > >> | + > >> | +.if defined(WITHOUT_X11) && !defined(WITHOUT_QT4) > >> | +BROKEN= QT4 frontend requires X11 support. Run 'make config' > >> again! > >> | +.endif > >> | + > > > > Why not enforce these required options instead? > > Lets assume a user want to install virtualbox headless on a server. He > deselect X11 and QT4 support but accidentally select NLS support. If we > enfore the required options this means we will install all the X11 and > QT4 dependencies without asking on his server. With the current checks > the user could decide if he wants to deselect NLS support or add QT4 and > X11 support. > There's also a possibility to disable NLS in WITHOUT_X11 case as well. My point it that on the servers one usually have WITHOUT_X11 defined in /etc/make.conf and build ports in batch mode. As virtualbox has NLS enabled by default this commit made default configuration broken for WITHOUT_X11 case. You can just give the user a warning about disabling NLS if it conflicts with the configuration selected and go ahead. -- Stanislav Sedov ST4096-RIPE
pgpR5ZukxAN8X.pgp
Description: PGP signature
