On Tue, Feb 09, 2010 at 11:23:27PM +0000, Dmitry Marakasov wrote:
> amdmi3 2010-02-09 23:23:27 UTC
>
> FreeBSD ports repository
>
> Modified files:
> audio Makefile
> Added files:
> audio/deadbeef Makefile distinfo pkg-descr pkg-plist
> audio/deadbeef/files patch-Makefile.am patch-Makefile.in
> patch-configure patch-configure.ac
> Log:
> DeaDBeeF (as in 0xDEADBEEF) is an audio player for GNU/Linux systems with
> X11 (though now it also runs in plain console without X, in FreeBSD,
> and in OpenSolaris).
>
> PR: 143670
> Submitted by: zloidemon <[email protected]>
^^^^^^^^^
Fully qualified person id (full name) should be used when available
(Whom: line of Makefile header).
>
> Revision Changes Path
> 1.1092 +1 -0 ports/audio/Makefile
> 1.1 +35 -0 ports/audio/deadbeef/Makefile (new)
COMMENT= DeaDBeeF is an audio player for GNU/Linux systems with X11
^^^^^^^^^^^^
Mentioning program name in COMMENT is redundant; simple "An audio
player..." would be enough. "GNU/Linux" also looks strange on BSD system.
"Unix[-like]" would be more appropriate.
> 1.1 +13 -0 ports/audio/deadbeef/files/patch-Makefile.am (new)
> 1.1 +21 -0 ports/audio/deadbeef/files/patch-Makefile.in (new)
Weird. Can you explain why both of these patches are required, since .in
is normally generated from .am (that is, patching .in is enough unless
the port needs more of autotools magic than simple "./configure")?
> 1.1 +57 -0 ports/audio/deadbeef/files/patch-configure (new)
> 1.1 +34 -0 ports/audio/deadbeef/files/patch-configure.ac (new)
Same here (if no autoconf required, patching .ac is useless).
./danfe
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[email protected]"
