On Sun, 14 Mar 2010 14:15:03 -0700, Doug Barton <[email protected]> wrote: > On 03/14/10 13:56, Bernhard Fröhlich wrote: >> Thanks for the patch! At the moment i do not have a possibility to >> double check them but the changes look good to me so please feel free to >> commit them. > > Ok, done. Thanks for the quick responses. :)
I found a problem with the commit yesterday. It's true that _flags is automatically append but only to "command" and not "start_cmd" so it does not work as it is now. So for testing I changed "start_cmd" to "command=/usr/local/bin/thin" and set "command_interpreter=%%PREFIX%%/bin/ruby18" and it started okay but rc.subr did not find the running binary. I investigated a little bit more and found that rc.subr:_find_processes searched for "ruby18: /usr/local/bin/thin" but the ps there only reported this: vs1# /bin/ps -ww -o pid= -o jid= -o command= -p 21778 21778 0 ruby18: thin server (0.0.0.0:3000) (ruby18) so it expects "thin" with his full path and therefor it does not find it. So changing command to "command=thin" does work and proves the theory vs1# /usr/local/etc/rc.d/redmine status /usr/local/etc/rc.d/redmine: WARNING: cannot read shebang line from thin redmine is running as pid 22176. but it breaks startup so it is no solution either. Okay that is the hard but correct way but I don't see a working solution at the moment so I propose the attached patch. This leaves everything as it is so command=%%RUBY_NAME%% to make _find_processes happy and use start_cmd with manually appending redmine_flags. If someone has a better solution i would like to know. Otherwise i would be happy if someone could commit the attached patch. Thanks! -- Bernhard Fröhlich http://www.bluelife.at/
redmine.in.patch
Description: Binary data
_______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[email protected]"
