On Wed, Mar 08, 2006 at 10:28:13PM +0000, Garance A Drosehn wrote:
> gad         2006-03-08 22:28:13 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.sbin/lpr/filters Makefile 
>     usr.sbin/lpr/filters.ru/koi2855 Makefile 
>     usr.sbin/lpr/filters.ru/koi2alt Makefile 
>   Log:
>   Switch these makefiles to use 'MAN=' to indicate they will not generate
>   a man page, instead of 'NO_MAN='.  'NO_MAN=' is something users would
>   set, not something a makefile should be using.
>   
>   Based on comments by:   des
>   
>   Revision  Changes    Path
>   1.6       +1 -1      src/usr.sbin/lpr/filters.ru/koi2855/Makefile
>   1.6       +1 -1      src/usr.sbin/lpr/filters.ru/koi2alt/Makefile
>   1.6       +1 -1      src/usr.sbin/lpr/filters/Makefile
> 
Please revert this change.  Users can set NO_MAN, indeed, to indicate
they don't want manpages.  But bsd.prog.mk makefiles that don't provide
a ${PROG}.1 manpage should set it (NO_MAN) themselves.  This way it's
also faster to process: bsd.prog.mk doesn't include bsd.man.mk.


Cheers,
-- 
Ruslan Ermilov
[EMAIL PROTECTED]
FreeBSD committer

Attachment: pgpzlGcTSU3th.pgp
Description: PGP signature

Reply via email to