On Thu, Mar 09, 2006 at 01:33:38AM +0000, Warner Losh wrote:
> imp         2006-03-09 01:33:38 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     share/mk             bsd.README 
>   Log:
>   Now that we now spell NO_MAN=xxx MAN=, update the docs.
>   
>   Submitted by: John Hein
>   
>   Revision  Changes    Path
>   1.30      +1 -1      src/share/mk/bsd.README
> 
I object.

1) This is not common:

grep '^NO_MAN=' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l
      10
grep '^MAN=[[:space:]]*(#.*)?$' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l
       0

2) MAN= is worse for performance (with NO_MAN, bsd.man.mk is not
   processes at all which is faster).

3) This is in contrast with NO_OBJ and similar knobs.

I can only suggest to make it spell "NO_MAN=", i.e., without any value.

Was there some discussion that I've missed?


Cheers,
-- 
Ruslan Ermilov
[EMAIL PROTECTED]
FreeBSD committer

Attachment: pgpEv03h9I9AN.pgp
Description: PGP signature

Reply via email to