This script has a couple of problems that I would like to see addressed.
The biggest one is the "autostart/restart" feature, which I don't think
is a good idea at all. I don't know what expectations the users of
openmq have in regards to this feature, but generally FreeBSD users
expect that the rc.d variables will control the starting of services.
More generally this script runs a lot of code unconditionally, which we
prefer not to do. The imq_vmargs bit can be in a start precmd method, as
well as the $autoargs and imq_brokerlist sections.
It's not clear to me what the value of the imq_start feature is, unless
it's just to save the pidfile. I don't think that's worth it, since
rc.subr has the capability to find a process with ps. At minimum the
_start method should run:
$command $imq_flags $command_args
since users might use the _flags variable, and have the reasonable
expectation that it should work.
Finally 2 minor issues, $Id$ should be changed to $FreeBSD$, and unless
there is a really good reason to run it earlier, we prefer ports rc.d
scripts to REQUIRE: LOGIN.
hth,
Doug
On 12/17/2010 02:37, Pav Lucistnik wrote:
pav 2010-12-17 10:37:04 UTC
FreeBSD ports repository
Modified files:
net/openmq Makefile distinfo
net/openmq/files imq.in
Log:
- Update to 4.5.b.1
- Support for easy cluster configuration in /etc/rc.conf. Just set
imq_brokerlist and you are ready to go.
PR: ports/153226
http://www.FreeBSD.org/cgi/query-pr.cgi?pr=153226
Submitted by: Radim Kolar<[email protected]> (maintainer)
Revision Changes Path
1.4 +9 -6 ports/net/openmq/Makefile
1.4 +4 -8 ports/net/openmq/distinfo
1.3 +9 -0 ports/net/openmq/files/imq.in
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/openmq/Makefile.diff?&r1=1.3&r2=1.4&f=h
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/openmq/distinfo.diff?&r1=1.3&r2=1.4&f=h
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/openmq/files/imq.in.diff?&r1=1.2&r2=1.3&f=h
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[email protected]"
