Pan Tsu writes: > Ashish SHUKLA <[email protected]> writes: >> ashish 2011-04-28 15:08:25 UTC >> >> FreeBSD ports repository >> >> Modified files: >> editors/emacs-devel Makefile distinfo >> editors/emacs-devel/files patch-Makefile.in >> patch-doc-emacs-Makefile.in >> patch-doc-lispintro-Makefile.in >> patch-doc-lispref-Makefile.in >> patch-doc-misc-Makefile.in >> Added files: >> editors/emacs-devel/files patch-configure.in >> Removed files: >> editors/emacs-devel/files patch-configure patch-src_config.in >> Log: >> - Update to bzr revision 104000.
> - Any reason to use autogen.sh instead of relying on AUTOTOOLS? Because autogen.sh works fine, and is provided by the upstream to configure the sources. So, I prefer to use upstream, unless it behaves badly. > - Why patch-src_config.in was lost and not converted to patch-configure.in? As I see, in src/config.in (excerpt is pasted below) which get generated already includes "stdlib.h", so I don't see any need of the re-including it, unless you think it causes some issue. --8<---------------cut here---------------start------------->8--- /* Define if the compiler supports function prototypes. It may do so but not define __STDC__ (e.g. DEC C by default) or may define it as zero. */ #undef PROTOTYPES #include <string.h> #include <stdlib.h> #ifdef HAVE_ALLOCA_H # include <alloca.h> #elif defined __FreeBSD__ #include <stdlib.h> #elif defined __GNUC__ # define alloca __builtin_alloca #elif defined _AIX # define alloca __alloca #else # include <stddef.h> # ifdef __cplusplus extern "C" # endif void *alloca (size_t); #endif --8<---------------cut here---------------end--------------->8--- > - No love for IMAGEMAGICK knob since > http://docs.freebsd.org/cgi/mid.cgi?86y6ahzpjp.fsf My sincere apologies for missing this diff, I'll include it, test it, and commit it today hopefully. Thanks -- Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 freebsd.org!ashish | http://people.freebsd.org/~ashish/ Avoid Success At All Costs !!
pgplp8lETgoAM.pgp
Description: PGP signature
