On Wed, Oct 26, 2011 at 12:44:51PM -0700, Doug Barton wrote:
> On 10/26/2011 09:20, Sunpoet Po-Chuan Hsieh wrote:
> > sunpoet 2011-10-26 16:20:00 UTC
> >
> > FreeBSD ports repository
> >
> > Modified files:
> > www/shellinabox Makefile
> > www/shellinabox/files shellinaboxd.in
> > Log:
> > - Unset shellinaboxd_user and shellinaboxd_group at the end of rc script
> > to
> > avoid unnecessary su(1) initiated by rc.subr
>
> I solved this in the named rc.d script by using _uid, which is not
> special to rc.subr; instead of _user, which is. Also, the following
> should probably be changed:
>
> if [ "${shellinaboxd_certfile}" = "" ]; then
>
> to
>
> if [ -n "${shellinaboxd_certfile}" ]; then
>
> Otherwise this script looks real good, thanks. :)Hi Doug, Using _uid/_gid is also a feasible solution to avoid unnecessary su. However, it would require users to change their rc.conf. That's why I choose to keep the old variable names. :) For shellinaboxd_certfile part, it's definitely better to use -z. Please commit your patch if maintainer approves. Thanks. Regards, sunpoet > > > - Pet portlint > > - Bump PORTREVISION for package change > > > > Reported by: ed (in the followup of ports/151314) > > Approved by: Olivier Cochard-Labbe <[email protected]> (maintainer) > > > > Revision Changes Path > > 1.6 +4 -4 ports/www/shellinabox/Makefile > > 1.6 +4 -1 ports/www/shellinabox/files/shellinaboxd.in > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/shellinabox/Makefile.diff?&r1=1.5&r2=1.6&f=h > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/shellinabox/files/shellinaboxd.in.diff?&r1=1.5&r2=1.6&f=h > > > > -- > > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go > > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ > -- Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org> 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
pgpSW2SRnwJD4.pgp
Description: PGP signature
