On Tue, 28 Mar 2006, Dag-Erling [iso-8859-1] Smørgrav wrote: > John Baldwin <[EMAIL PROTECTED]> writes: > > s/off/on/ I trust > > > > Not true. The tinderbox would attest to that. Please see code such as > > this: [...] > > which uses uintptr_t, not actual pointers, to avoid warnings. In > effect, that code is broken. > > Apply the attached patch, see how far a buildkernel gets... > > I think the proper thing to do, to cover all your bases, would be to > define a MD atomic_*_intptr family which operated on uintptr_t, and > define an MI atomic_*_ptr family which operates on void * based on > that.
I would like to see that. > > Even userland uses casts when it uses void * rather than uintptr_t for > > the underlying type. See src/lib/libpthread/sys/lock.c or > > src/lib/libthr/thr_umtx.h. I didn't like having to do that in libpthread. It was confusing to me. I'd be happy if I never had to deal with uintptr_t. > > The latter only works because libthr is built with warnings disabled. > I just finished working on making it build at WARNS level 2; higher > levels will require a major overhaul, because the kernel interface it > uses is fundamentally broken. > > DES > -- DE _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
