On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote:
> rm          2012-01-13 03:38:22 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     audio/clementine-player Makefile
>   Added files:
>     audio/clementine-player/files patch-src-devices-cddadevice.h
>                                   patch-src-devices-cddalister.cpp
>   Log:
>   - let it build with stock gcc
>   - optionify ipod and mtp support (default on)

This type of `port optionification' leads to a nasty problem of hidden 
dependencies when options are unchecked, but corresponding libraries are 
presented. Please consider to commit the patch, which makes optional support 
really optional.

Max

 
>   PR:             164043
>   Submitted by:   Axel Gonzalez <loox at e-shell dot net>
>   Approved by:    maintainer
> 
>   Revision  Changes    Path
>   1.13      +14 -13    ports/audio/clementine-player/Makefile
>   1.1       +15 -0    
> ports/audio/clementine-player/files/patch-src-devices-cddadevice.h (new)
> 1.1       +16 -0    
> ports/audio/clementine-player/files/patch-src-devices-cddalister.cpp (new)

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/audio/clementine-player/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile	13 Jan 2012 03:38:22 -0000	1.13
+++ Makefile	16 Jan 2012 18:07:01 -0000
@@ -54,14 +54,20 @@
 
 .if defined(WITH_LASTFM)
 LIB_DEPENDS+=	lastfm.0:${PORTSDIR}/audio/liblastfm
+.else
+CMAKE_ARGS+=	-DENABLE_LIBLASTFM=Off
 .endif
 
 .if defined(WITH_GPOD)
 LIB_DEPENDS+=	gpod.7:${PORTSDIR}/audio/libgpod
+.else
+CMAKE_ARGS+=	-DENABLE_LIBGPOD=Off
 .endif
 
 .if defined(WITH_MTP)
 LIB_DEPENDS+=	mtp.11:${PORTSDIR}/audio/libmtp
+.else
+CMAKE_ARGS+=	-DENABLE_LIBMTP=Off
 .endif
 
 .include <bsd.port.post.mk>
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to