On 20 March 2012 02:29, Wesley Shields <[email protected]> wrote: > On Mon, Mar 19, 2012 at 10:32:44AM -0400, Michael Scheidell wrote: >> >> >> On 3/19/12 10:30 AM, Wesley Shields wrote: >> > Isn't it better to use ${INSTALL_DATA} here? >> > >> > -- WXS >> open a pr, let maintainer approve it. > > As the person who committed this it is your responsibility to see that > issues raised are properly fixed. If you feel like the maintainer should > be brought in for such a simple change that is your decision to make, > but I shouldn't have to open a PR to address this. > >> Id also like to see examples wrapper in a .if/endif and pkg-plist >> prefixed with %%PORTEXAMPLES%%%EXAMPLES%% . > > Would be nice to have also, but not my point. Using ${INSTALL_DATA} is > the right thing to do because it sets the owner and mode properly.
Actually, the code is completely incorrect because the do-install target removes the files from WRKSRC, meaning that if you try to install twice you have to re-extract and start all over again. Please fix this, you should not dump code in the repo and tell other people to fix your mistakes. Chris _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[email protected]"
