Quoting "Andrew Pantyukhin" <[EMAIL PROTECTED]> (Mon, 31 Jul 2006 19:38:33 +0400):
> On 7/31/06, Alexander Leidinger <[EMAIL PROTECTED]> wrote: > > Quoting Andrew Pantyukhin <[EMAIL PROTECTED]> (Sun, 30 Jul 2006 22:34:30 > > +0000 (UTC)): > > > > > sat 2006-07-30 22:34:30 UTC > > > > > > FreeBSD ports repository > > > > > > Modified files: > > > Mk bsd.linux-rpm.mk > > > Log: > > > - Only set default m_s_subdir if master_sites was undefined > > > > Would you please describe which problem this commit tries to solve > > (perhaps as a forced commit)? > > Fedora has a rather unique MSS scheme (related to its versioning) > and applying the scheme to another MS does not seem very > practical. In practice, a more relevant default value might be > attempted to be set after bsd.linux-rpm.mk. The default linux base is FC4, and most linux-infrastructure ports are from FC4 too. Those ports are the only ports which use this stuff ATM. So ATM it's very practical. > > I'm not sure if we have some ports which set MS but depend on the auto > > assigning of MSS, but I would not be surprised if we have such ports. > > Did you check for such ports? > > Sure. There are 29 USE_LINUX_RPM ports, only three set MS, > two of them don't need MSS at all and the third one would rather > MSS was not touched by linux-rpm.mk. Which port is the third one? > I'm sorry I committed this without prior discussion, but I tried to > make sure the change was not desctructive and as simple as it > gets. The mk is used by a lot of ports, so any bug may harm a lot of ports. I don't object if you want to join us at emulation@ (actually I would be very happy to see more contributors), but a review request for changes with a high impact ratio (in case of a bug) would be very nice next time. Bye, Alexander. -- Sometimes one should just look at things and think about things without doing things. -- Calvin http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
