On Mon, 14 Aug 2006, Dag-Erling Smorgrav wrote:
des 2006-08-14 13:28:53 UTC
FreeBSD src repository
Modified files:
sys/conf kern.post.mk kmod.mk
sys/modules/if_ef Makefile
sys/modules/if_ppp Makefile
sys/modules/netgraph/mppc Makefile
sys/modules/sound/sound Makefile
Log:
Don't use touch when what is really meant is :> (create an empty file, or
truncate it if it exists) or :>> (ensure the file exists, but don't change
it if it already does)
Why not just ">" or ">>"?
Reviewed by: ru
MFC after: 2 weeks
Revision Changes Path
1.96 +1 -1 src/sys/conf/kern.post.mk
1.210 +2 -2 src/sys/conf/kmod.mk
1.14 +4 -4 src/sys/modules/if_ef/Makefile
1.36 +3 -3 src/sys/modules/if_ppp/Makefile
1.14 +1 -1 src/sys/modules/netgraph/mppc/Makefile
1.19 +1 -1 src/sys/modules/sound/sound/Makefile
I use echo -n for one of these. "echo" is less cryptic than ">", and
is probably faster since /bin/echo is smaller than /bin/sh and is used
enough to keep it cached.
In sound/Makefile, the cleanup should be to remove the touching (now
emptying) since the touching used to be just worse than the default of
emptying and is now just the same as the default (but takes extra code).
Emptying instead of touching could in theory handle things changing
underneath, but it doesn't actually help for most cases since most
cases involve options files and opt_foo.h never (?) has any dependencies,
so opt_foo.h only gets touched/created when it doesn't already exist.
In sound/Makefile, it made even less difference because it would take
${MACHINE_ARCH} changing underneath to change the correct contents of
the options file.
Bruce
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
