M. Warner Losh wrote:
In message: <[EMAIL PROTECTED]>
Nate Lawson <[EMAIL PROTECTED]> writes:
: Warner Losh wrote:
: > imp 2007-01-22 04:34:03 UTC
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/cam/scsi scsi_da.c
: > Log:
: > Add quirk for EasyMP3 EM732X usb 2.0 flash mp3 player.
: > (It appears that the quirk proceedures link has disappeared and that
: > this PR complied with it, if there's a problem, please contact me).
: >
: > PR: usb/96546
: >
: > Revision Changes Path
: > 1.201 +8 -0 src/sys/cam/scsi/scsi_da.c
: >
: >
: > Index: src/sys/cam/scsi/scsi_da.c
: > diff -u src/sys/cam/scsi/scsi_da.c:1.200 src/sys/cam/scsi/scsi_da.c:1.201
: > --- src/sys/cam/scsi/scsi_da.c:1.200 Tue Dec 5 07:45:28 2006
: > +++ src/sys/cam/scsi/scsi_da.c Mon Jan 22 04:34:03 2007
: > @@ -466,6 +466,14 @@
: > {T_DIRECT, SIP_MEDIA_REMOVABLE, "X-Micro", "Flash Disk",
: > "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
: > },
: > + {
: > + /*
: > + * EasyMP3 EM732X USB 2.0 Flash MP3 Player
: > + * PR: usb/96546
: > + */
: > + {T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "MP3 Player*",
: > + "1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
: > + },
: > };
: >
: > static disk_strategy_t dastrategy;
:
: Um, this matches every device that has "MP3 Player" somewhere in it.
: Are you sure it doesn't have a vendor string?
See the PR for details and suggest something better.
Warner
According to the submitter:
pass0: <EM732X MP3 Player 1.00> Removable Direct Access SCSI-0 device
So the vendor string should be set to "EM732X" and retested. Blank
("*") vendor or device strings should not be committed.
--
Nate
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
