Doug Barton <[EMAIL PROTECTED]> writes: > Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes: > > Doug Barton <[EMAIL PROTECTED]> writes: > > > Meanwhile, I've attached a patch that simplifies the hostid_hardware() > > > quite a bit, and has the added virtue of only calling csh if it's > > > needed. > > It also fails to ensure that the UUID has the correct syntax. > If we're really concerned that this could be a problem (and I don't > know enough about it to comment) then feel free to wrap a syntax test > around the last echo. What I'm trying to do is simplify the routine, > and allow obviously bogus responses to be rejected with cheap tests. > > Given that this thing is on by default, and that people are always > complaining that rc.d stuff runs too slow, we need to be a little more > careful to do it well, rather than just good enough.
The current code correctly checks for a syntactically correct UUID. Your proposed replacement does not. I fail to see how that qualifies as "doing well rather than just good enough" DES -- Dag-Erling Smørgrav - [EMAIL PROTECTED] _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
