On 6/14/07, Martin Matuska <[EMAIL PROTECTED]> wrote:
mm 2007-06-13 23:39:01 UTC
FreeBSD ports repository
Modified files:
irc/inspircd Makefile pkg-plist
Log:
- bugfix: example files install and their pkg-plist entries
- added USE_LDCONFIG entry
PR: ports/113502
Submitted by: Craig Edwards <[EMAIL PROTECTED]> (maintainer)
Pointyhat to: sat
Approved by: maintainer, garga (mentor)
Revision Changes Path
1.6 +6 -0 ports/irc/inspircd/Makefile
1.3 +17 -8 ports/irc/inspircd/pkg-plist
I assume there was some loss of communication, but
this commit could have been preceded by a courtesy
ping to me and/or Beech, who have been working on
a similar fix.
Index: ports/irc/inspircd/Makefile
diff -u ports/irc/inspircd/Makefile:1.5 ports/irc/inspircd/Makefile:1.6
--- ports/irc/inspircd/Makefile:1.5 Wed Jun 13 22:05:22 2007
+++ ports/irc/inspircd/Makefile Wed Jun 13 23:39:01
@@ -18,6 +19,7 @@
WRKSRC= ${WRKDIR}/inspircd
USE_GMAKE= yes
USE_BZIP2= yes
+USE_LDCONFIG= ${PREFIX}/lib/inspircd
Really? I'd be grateful if you explained why this is
needed.
# Configure script is written in perl
USE_PERL5_BUILD=yes
@@ -46,5 +48,9 @@
@${STRIP_CMD} ${PREFIX}/lib/inspircd/modules/*.so
@${STRIP_CMD} ${PREFIX}/lib/inspircd/*.so
@${STRIP_CMD} ${PREFIX}/bin/inspircd
+.for FILE in censor conf filter helpop motd quotes rules
+ @${TEST} -f ${PREFIX}/etc/inspircd/inspircd.${FILE} || \
+ ${CP} ${PREFIX}/etc/inspircd/inspircd.${FILE}.example
${PREFIX}/etc/inspircd/inspircd.${FILE}
+.endfor
We don't use this type of conditional in ports. It fails
with non-zero status. Instead you should use if;then;fi,
which always exits 0.
Finally, you should rethink the meaning of pointy hats
before handing them out so easily. I'm generous to issue
them to myself and happy when others fix my mess and give
me one. This commit clumsily enables a convenience feature,
which has its merit and would have been fixed by Beech in
a moment, but was not important altogether. The other part
of this commit is a bogus noop.
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
