On 6/16/07, Alexey Dokuchaev <[EMAIL PROTECTED]> wrote:
On Sat, Jun 16, 2007 at 10:23:09AM +0400, Andrew Pantyukhin wrote: > On 6/16/07, Pav Lucistnik <[EMAIL PROTECTED]> wrote: > >Andrew Pantyukhin p????e v so 16. 06. 2007 v 01:20 +0400: > > > >> > -WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} > >> > -PKGMESSAGE= ${WRKSRC}/pkg-message > >> > -USE_MOTIF= yes > >> > USE_BISON= yes > >> > USE_GMAKE= yes > >> > +USE_MOTIF= yes > >> > + > >> > +WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} > >> > +SUB_FILES+= pkg-message > >> > >> PKGMESSAGE defaults to PKGDIR/pkg-message. If we > >> have it processed with SUB_FILES, it will end up > >> in WRKDIR/pkg-message > > > >So? His usage of SUB_FILES is perfectly fine. > > What I can't seem to understand is why PKGMESSAGE is > changing from PKGDIR/pkg-message to WRKDIR/pkg-message > when SUB_FILES=pkg-message is defined.Probably because of this: bpm, around line 5554: .for i in pkg-message pkg-install pkg-deinstall pkg-req .if ${SUB_FILES:M${i}*}!="" ${i:S/-//:U}= ${WRKDIR}/${SUB_FILES:M${i}*} .endif .endfor
Hacky, but cool. Unfortunately it was never mentioned in CHANGES, nor even in commit message (*wink at krion and flz*). The only docs we have is ports/67151 and code. Not that it requires any decoding, but a quick grep discovers over 300 definitions of PKGMESSAGE which were never needed (that's over a half of all pkg-message preprocessing cases). So much for innovation. _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
