In message: <[EMAIL PROTECTED]>
Robert Watson <[EMAIL PROTECTED]> writes:
: On Thu, 28 Jun 2007, Robert Watson wrote:
:
: > rwatson 2007-06-28 12:54:58 UTC
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/netatalk aarp.h ddp.h
: > Log:
: > Mark wire data structures in netatalk as __packed so that they are
: > properly (un)padded on the arm platform. With this change, FreeBSD/arm
: > boxes are able to route AppleTalk properly.
: >
: > Submitted/tested by: Nathan Whitehorn <nathanw at uchicago dot edu>
: > Tested on: arm, i386, amd64
: > Approved by: re (kensmith)
:
: We've now scattered __packed in a number of protocols, but I can't help but
: wonder if we shouldn't generally be doing a sweep of callers to mtod() to
find
: all places where we cast wire data structures to C structures and checking
: padding across platforms. It would also be good to add more CTASSERT's about
: wire data structure sizes beside their definitions.
More couldn't hurt...
Warner
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
