On 09/07/07, Warner Losh <[EMAIL PROTECTED]> wrote:
imp 2007-07-09 16:58:08 UTCFreeBSD src repository Modified files: sys/dev/usb if_rue.c Log: When all the other drivers were converted to scheduling a taskqueue to do the heavy lifting of the 'mii_tick' function, rue was left behind. Implement this in a naive way. Reports from the field show this makes the driver functional with some locking issues, as opposed to an instant panic. Those will be addressed in a later version of the driver. Approved by: re@ (bmah) Revision Changes Path 1.40 +18 -0 src/sys/dev/usb/if_rue.c
I think you forgot to commit a change to src/sys/dev/usb/if_ruereg.h: /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: warning: left-hand operand of comma expression has no effect /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:598: warning: left-hand operand of comma expression has no effect /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c: In function 'rue_detach': /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:710: error: 'struct rue_softc' has no member named 'rue_tick_task' /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c: In function 'rue_tick': /usr/src/HEAD/p4/src/sys/dev/usb/if_rue.c:931: error: 'struct rue_softc' has no member named 'rue_tick_task' Cheers, Constantine. _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
