Peter Jeremy wrote:
On Wed, Jan 09, 2008 at 09:34:03AM -0800, Sam Leffler wrote:
I observe that netbsd does these sorts of changes in sweeps over the tree
and w/ multiple people involved to review each other's work. I'd be more
confident if I saw commits like this include a "Reviewed by:" line.
For this sort of commit, it should also be possible to check that you
haven't broken anything by cmp(1)ing the .o files or manually preprocessing
and diffing the preprocessed files.
For this specific case md5 checksums of the resulting .o files should
work. However some committers have a history of making changes like
this that either break the build (w/o a quick followup to correct the
problem) or introduce subtle issues that aren't found until much later.
Hence my request (removed by obrien) that people do changes like this
when they are actively working on a section of code. Drive-by commits
like this frequently do more harm than good.
Sam
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
