On Friday 11 January 2008 11:50:53 am Konstantin Belousov wrote:
> kib         2008-01-11 16:50:53 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/fdc          fdc.c 
>   Log:
>   The wakeup() line from the rev. 1.319 is wrong and reintroduces
>   a panic race on module unload. The wakeup() is internal to
>   kproc_exit/kthread_exit. The correct fix is to fix the msleep() in
>   detach to sleep on fdc->fdc_thread instead of &fdc->fdc_thread.
>   
>   Noted and reviewed by:  jhb
>   Pointy hat to:  kib
>   MFC after:      1 week

Original pointy hat to: jhb

As I missed updating the msleep() when I fixed the unload race the first
time around which lead to the hang seen in the original PR.

-- 
John Baldwin
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to