CVSROOT:        /cvs/gnome
Module name:    gnome-panel
Changes by:     markmc  05/05/02 10:59:32

Modified files:
        gnome-panel    : Tag: gnome-2-10 ChangeLog egg-recent-view-gtk.c 
                         panel-menu-items.c panel-recent.c 
                         panel-recent.h 

Log message:
2005-05-02  Mark McLoughlin  <[EMAIL PROTECTED]>

Change things around so that we don't 1) slave the lifecycle
of the EggRecentViewGtk to the menu it manages, 2) incorrectly
unref the menu after creating the view and 3) take a ref on
the menu in EggRecentViewgtk.

* panel-recent.[ch]: (panel_recent_append_documents_menu):
Re-work so that it returns the newly created EggRecentViewGtk
and allows it to be re-used by passing it back in as a parameter.

* panel-menu-items.c:
(panel_place_menu_item_create_menu): hold a ref on the
EggRecentViewGtk and re-user when re-creating the menu.
(panel_place_menu_item_finalize): unref the view.

* egg-recent-view-gtk.c:
(egg_recent_view_gtk_clear),
(egg_recent_view_gtk_set_list): don't barf if view->menu is NULL.
(egg_recent_view_gtk_finalize): don't unref the menu.
(egg_recent_view_gtk_set_menu): don't take a ref on the menu.
There's no point in us updating a menu which has been destroyed.

URL : 
http://cvs.gnome.org/bonsai/cvsquery.cgi?branch=&dir=gnome-panel&who=markmc&date=explicit&mindate=2005-05-02%2010:58&maxdate=2005-05-02%2011:00

_______________________________________________
cvs-commits-list mailing list
cvs-commits-list@gnome.org
http://mail.gnome.org/mailman/listinfo/cvs-commits-list

Reply via email to