Claus Reinke wrote:
Hi Simon,

I've tested your patches - unfortunately they fail the tests for me. Multi-line commands apparently work via readline, but not when piped into stdin.

i don't know what you mean? the tests worked on my platform,
and piping from stdin seems to work fine for me. see log below.
could you tell me what exactly your tests say?

ghci023,024,025 all fail, for various reasons. To be fair I can see why 024 fails and I can fix that. ghci023 seems to be caused by ^M - if I run the script through dos2unix I get the right results. Does that help?

====> Running ./prog008/prog008.T
====> Running ./scripts/all.T
=====> ghci023(ghci)
cd ./scripts && HC='/64playpen/simonmar/testing/compiler/stage2/ghc-inplace' HC_OPTS='-dcore-lint -dcmm-lint -Dx86_64_unknown_linux ' '/64playpen/simonmar/testing/compiler/stage2/ghc-inplace' --interactive -v0 -ignore-dot-ghci-dcore-lint -dcmm-lint -Dx86_64_unknown_linux <ghci023.script >ghci023.run.stdout 2>ghci023.run.stderr
Actual stdout output differs from expected:
--- ./scripts/ghci023.stdout.normalised 2007-10-17 14:49:36.000000000 +0100
+++ ./scripts/ghci023.run.stdout.normalised 2007-10-17 14:49:36.000000000 +0100
@@ -1,16 +1,2 @@
 -- testing ghci multiline commands :{ .. :}
 -- via stdin
-(1,2,3)
-data Maybe a = Nothing | Just a
-maybe :: b -> (a -> b) -> Maybe a -> b
-isJust :: Maybe a -> Bool
-isNothing :: Maybe a -> Bool
-fromJust :: Maybe a -> a
-fromMaybe :: a -> Maybe a -> a
-maybeToList :: Maybe a -> [a]
-listToMaybe :: [a] -> Maybe a
-catMaybes :: [Maybe a] -> [a]
-mapMaybe :: (a -> Maybe b) -> [a] -> [b]
--- via readFile
-(True,False)
-id :: a -> a
*** unexpected failure for ghci023(ghci)
=====> ghci024(ghci)
cd ./scripts && HC='/64playpen/simonmar/testing/compiler/stage2/ghc-inplace' HC_OPTS='-dcore-lint -dcmm-lint -Dx86_64_unknown_linux ' '/64playpen/simonmar/testing/compiler/stage2/ghc-inplace' --interactive -v0 -ignore-dot-ghci-dcore-lint -dcmm-lint -Dx86_64_unknown_linux <ghci024.script >ghci024.run.stdout 2>ghci024.run.stderr
Actual stdout output differs from expected:
--- ./scripts/ghci024.stdout.normalised 2007-10-17 14:49:37.000000000 +0100
+++ ./scripts/ghci024.run.stdout.normalised 2007-10-17 14:49:37.000000000 +0100
@@ -69,7 +69,7 @@
   -XParallelListComp
   -XForeignFunctionInterface
   -XUnliftedFFITypes
-  -XPartiallyAppliedClosedTypeSynonyms
+  -XLiberalTypeSynonyms
   -XRankNTypes
   -XTypeOperators
   -XRecursiveDo
@@ -99,12 +99,13 @@
 active package flags:
   -package ghc
 packages currently loaded:
-  ghc-6.9.20070917
+  ghc-6.9
   haskell98
   random-1.0
   Cabal-1.2.0
+  readline-1.0
   process-1.0
-  Win32-2.1
+  unix-2.0
   template-haskell
   packedstring-0.1
   pretty-1.0
*** unexpected failure for ghci024(ghci)
=====> ghci025(ghci)
cd ./scripts && HC='/64playpen/simonmar/testing/compiler/stage2/ghc-inplace' HC_OPTS='-dcore-lint -dcmm-lint -Dx86_64_unknown_linux ' '/64playpen/simonmar/testing/compiler/stage2/ghc-inplace' --interactive -v0 -ignore-dot-ghci-dcore-lint -dcmm-lint -Dx86_64_unknown_linux <ghci025.script >ghci025.run.stdout 2>ghci025.run.stderr
Actual stdout output differs from expected:
--- ./scripts/ghci025.stdout.normalised 2007-10-17 14:49:38.000000000 +0100
+++ ./scripts/ghci025.run.stdout.normalised 2007-10-17 14:49:38.000000000 +0100
@@ -33,16 +33,16 @@
 mapMaybe :: (a -> Maybe b) -> [a] -> [b]
 maybeToList :: Maybe a -> [a]
 -- imported from Control.Monad
-mzero :: (MonadPlus m) => m a
 mplus :: (MonadPlus m) => m a -> m a -> m a
--- imported from Data.Maybe, Prelude
-data Maybe a = Nothing | Just a
+mzero :: (MonadPlus m) => m a
 -- imported from Control.Monad, Prelude, T
 class Monad m where
   (>>=) :: m a -> (a -> m b) -> m b
   (>>) :: m a -> m b -> m b
   return :: a -> m a
   fail :: GHC.Base.String -> m a
+-- imported from Data.Maybe, Prelude
+data Maybe a = Nothing | Just a
 -- imported from Prelude
 class Eq a where
   (GHC.Base.==) :: a -> a -> GHC.Base.Bool
@@ -60,7 +60,6 @@
   c3 :: a1 -> b
   c4 :: a1 -> b
 -- defined locally
-T.length :: Integer
 class C a b where
   c1 :: (N b) => a -> b
   c2 :: (N b, S b) => a -> b
@@ -72,8 +71,8 @@
 c4 :: (C a b) => a1 -> b
 class S a
 class N a
--- defined locally
 T.length :: Integer
+-- defined locally
 class C a b where
   c1 :: (N b) => a -> b
   c2 :: (N b, S b) => a -> b
@@ -85,3 +84,4 @@
 c4 :: forall a b. (C a b) => forall a1. a1 -> b
 class S a
 class N a
+T.length :: Integer
*** unexpected failure for ghci025(ghci)
====> Running ./prog007/prog007.T
====> Running ./prog001/prog001.T
====> Running ./prog005/prog005.T
====> Running ./prog002/prog002.T
====> Running ./prog004/prog004.T
====> Running ./prog006/prog006.T
====> Running ./prog003/prog003.T
====> Running ./should_run/all.T

OVERALL SUMMARY for test run started at Wed Oct 17 14:49:36 BST 2007
      36 total tests, which gave rise to
      54 test cases, of which
       0 caused framework failures
      51 were skipped

       0 expected passes
       0 expected failures
       0 unexpected passes
       3 unexpected failures

Unexpected failures:
   ghci023(ghci)
   ghci024(ghci)
   ghci025(ghci)

_______________________________________________
Cvs-ghc mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/cvs-ghc

Reply via email to