Oops yes. I'm fixing. Church2 is odd. Even in its "working" state the error message is poor -- and impredicativity is (still) up in the air. So I'll probably mark it as expect-broken.
S | -----Original Message----- | From: Manuel M T Chakravarty [mailto:[EMAIL PROTECTED] | Sent: 22 November 2007 00:47 | To: Simon Peyton-Jones | Cc: [email protected] | Subject: Re: patch applied (ghc): Make rebindable do-notation behave as advertised | | Simon, | | Is it possible that you forgot to push a corresponding patch to the | testsuite. I get | | Unexpected passes: | Church2(normal) | | Unexpected failures: | TH_exn2(normal) | break003(ghci) | break021(ghci) | openFile008(normal) | rw(normal) | tcfail168(normal) | tcfail178(normal) | | All except Church2 and openFile008 seem to be related to this patch. | | Manuel | | > Wed Nov 21 09:49:14 PST 2007 [EMAIL PROTECTED] | > * Make rebindable do-notation behave as advertised | > | > Adopt Trac #1537. The patch ended up a bit bigger than I expected, | > so I suggest we do not merge this into the 6.8 branch. But there | > is no funadamental reason why not. | > | > With this patch, rebindable do-notation really does type as if you | > had written the original (>>) and (>>=) operations in desguared form. | > | > I ended up refactoring some of the (rather complicated) error-context | > stuff in TcUnify, by pushing an InstOrigin into tcSubExp and its | > various calls. That means we could get rid of tcFunResTy, and the | > SubCtxt type. This should improve error messages slightly | > in complicated situations, because we have an Origin to hand | > to instCall (in the (isSigmaTy actual_ty) case of tc_sub1). | > | > Thanks to Pepe for the first draft of the patch. | > | > | > M ./compiler/typecheck/TcBinds.lhs -2 +3 | > M ./compiler/typecheck/TcExpr.lhs -11 +13 | > M ./compiler/typecheck/TcMatches.lhs -25 +24 | > M ./compiler/typecheck/TcPat.lhs -1 +3 | > M ./compiler/typecheck/TcRnDriver.lhs -2 +1 | > M ./compiler/typecheck/TcRnTypes.lhs -2 +10 | > M ./compiler/typecheck/TcUnify.lhs -77 +50 | > | > _______________________________________________ | > Cvs-ghc mailing list | > [email protected] | > http://www.haskell.org/mailman/listinfo/cvs-ghc _______________________________________________ Cvs-ghc mailing list [email protected] http://www.haskell.org/mailman/listinfo/cvs-ghc
