Hmm. I'm not sure you are done yet! What happens if you say
map ((#,#) True) xs
?
You'll probably end up with a link error, because there is no curried function
(#,#). With a regular data type, we inject the (rather odd-looking) function
(,) = \a \b. (a,b)
and similarly for all data type declarations, just so that there is a current
(,) function defined.
The right place to add these functions (presumably only up to some fixed arity)
is probably in the code that generates PrimopWrappers.hs. The program that
does this is in utils/genprimopcode/Main.hs.
Does that give you enough to go on. You can commit your patch anyway, but it'd
be great to finish the job.
Do you want to tackle (2) on #1509. I can explain what's needed...
Simon
| -----Original Message-----
| From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Simon Marlow
| Sent: 02 January 2008 14:28
| To: Isaac Dupree
| Cc: BuildBot Collator
| Subject: Re: darcs patch: implement prefix unboxed tuples syntax (#1509)
|
| Isaac Dupree wrote:
| > attached are patches for ghc and for testsuite. They seem pretty
| > straightforward. Adding prefix-unboxed-tuples turned out to just
| > require a parser modification -- ( contrary to a comment in
| > http://hackage.haskell.org/trac/ghc/ticket/1509 ) for GHC at least,
| > Data.Tuple only defines data types and constructors (and Eq,Ord...
| > instances) of (boxed) tuples; unboxed tuples were already built-in, (or
| > anyway my test passed and ran successfully after a simple parser
| > addition). --should the test be in should_run instead of should_compile,
| > because it is runnable and I did manually test running it, or not
| > because it would just waste test-running time now that I've seen once
| > that it can run, and it being mostly a parser test, backed up by
| > typechecking?
| >
| > proposed review deadline: 12 January (I'm pretty confident that these
| > changes are correct)
| >
| > P.S. HEAD's ./validate has had some testsuite errors for a while
|
| Looks good to me, I have no objections to your committing it.
|
| Cheers,
| Simon
|
| _______________________________________________
| Cvs-ghc mailing list
| [email protected]
| http://www.haskell.org/mailman/listinfo/cvs-ghc
_______________________________________________
Cvs-ghc mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/cvs-ghc
