The first patch is a partial fix for ticket #2176
"H98 module Array exports non-H98 instance Functor ((->) a)"
The other two are just cleanups.
Duncan
Tue Mar 25 15:02:17 GMT 2008 Duncan Coutts <[EMAIL PROTECTED]>
* Don't import Control.Applicative just to get <$> use fmap
The real reason to not import Control.Applicative is that it exports
the non-H98 instance Functor ((->) a) and it is important for
Data.Array to not re-export that because the H98 Array module
re-exports bits of Data.Array and it is vital that we do not export
non-H98 instances from a module specified in H98.
Tue Mar 25 15:08:54 GMT 2008 Duncan Coutts <[EMAIL PROTECTED]>
* Be explicit about more imports in Data.Array
Tue Mar 25 15:36:14 GMT 2008 Duncan Coutts <[EMAIL PROTECTED]>
* Improve the .cabal file
Specify the build-type and min cabal-version.
Don't have Data.Array in both exposed-modules on both sides of a
conditional, just make it unconditional.
Stop using -fglasgow-exts and specify all the extensions explicitly.
Some extensions are conditional on non-nhc98 and some are ghc-specific.
New patches:
[Don't import Control.Applicative just to get <$> use fmap
Duncan Coutts <[EMAIL PROTECTED]>**20080325150217
The real reason to not import Control.Applicative is that it exports
the non-H98 instance Functor ((->) a) and it is important for
Data.Array to not re-export that because the H98 Array module
re-exports bits of Data.Array and it is vital that we do not export
non-H98 instances from a module specified in H98.
] {
hunk ./Data/Array.hs 74
-import Control.Applicative
hunk ./Data/Array.hs 95
- traverse f arr = listArray (bounds arr) <$> traverse f (elems arr)
+ traverse f arr = listArray (bounds arr) `fmap` traverse f (elems arr)
}
[Be explicit about more imports in Data.Array
Duncan Coutts <[EMAIL PROTECTED]>**20080325150854] {
hunk ./Data/Array.hs 60
-import GHC.Arr -- Most of the hard work is done here
-import Data.Generics.Basics -- To provide a Data instance
-import Data.Generics.Instances -- To provide a Data instance
-import GHC.Err ( error ) -- Needed for Data instance
+import GHC.Arr -- Most of the hard work is done here
+import Data.Generics.Basics () -- To provide a Data instance
+import Data.Generics.Instances () -- To provide a Data instance
+import GHC.Err ( error ) -- Needed for Data instance
hunk ./Data/Array.hs 74
-import Data.Foldable
-import Data.Typeable
-import Data.Traversable
+import Data.Foldable ( Foldable(foldr) )
+import Data.Typeable () -- For the Typeable instance
+import Data.Traversable ( Traversable(traverse) )
}
[Improve the .cabal file
Duncan Coutts <[EMAIL PROTECTED]>**20080325153614
Specify the build-type and min cabal-version.
Don't have Data.Array in both exposed-modules on both sides of a
conditional, just make it unconditional.
Stop using -fglasgow-exts and specify all the extensions explicitly.
Some extensions are conditional on non-nhc98 and some are ghc-specific.
] {
hunk ./array.cabal 11
-library {
+cabal-version: >=1.2
+build-type: Simple
+
+library
hunk ./array.cabal 16
- if impl(nhc98)
- exposed-modules:
+ exposed-modules:
hunk ./array.cabal 18
- else
+ extensions: CPP
+ if !impl(nhc98)
hunk ./array.cabal 21
- Data.Array
hunk ./array.cabal 31
- extensions: CPP
+ extensions:
+ MultiParamTypeClasses,
+ FlexibleContexts,
+ FlexibleInstances,
+ TypeSynonymInstances
+ if impl(ghc)
+ extensions:
+ Rank2Types,
+ MagicHash,
+ UnboxedTuples,
+ ForeignFunctionInterface,
+ UnliftedFFITypes
hunk ./array.cabal 44
- ghc-options: -fglasgow-exts
-}
}
Context:
[add instances for Bool DiffUArrays
Matti Niemenmaa <[EMAIL PROTECTED]>**20080302144957]
[new-style haddock attribute
Ross Paterson <[EMAIL PROTECTED]>**20080123143925]
[Fix freeze: It was trying to be safe, but in the end calling an unsafe function
Ian Lynagh <[EMAIL PROTECTED]>**20071214203804]
[FIX BUILD: build-depends should be inside library { ... }
Simon Marlow <[EMAIL PROTECTED]>**20071214090946]
[use cabal configurations to select modules to build with nhc98
[EMAIL PROTECTED]
[Hugs: add Eq instance for STUArray
Ross Paterson <[EMAIL PROTECTED]>**20071023184024]
[FIX #1270: add Eq instances for STUArray and IOUArray
Simon Marlow <[EMAIL PROTECTED]>**20071023132447]
[Add a boring file
Ian Lynagh <[EMAIL PROTECTED]>**20070913204639]
[TAG 2007-09-13
Ian Lynagh <[EMAIL PROTECTED]>**20070913215738]
Patch bundle hash:
bb36759bec7d4c88411aaacff373bdc7f77addab
_______________________________________________
Cvs-ghc mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/cvs-ghc
