Simon Marlow wrote:
Ian Lynagh wrote:

HEAD validates for me both with and without your workaround. I have:

$ gcc --version
i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5465)

Won't the workaround break when Apple ships gcc 4.3?

Yes, it would break if a future Apple gcc follows the standard gcc in this regard. So for that reason I propose we use

#if defined(__GNUC_GNU_INLINE__) && !defined(__APPLE__)
#  if defined(KEEP_INLINES)
#    define EXTERN_INLINE inline
#  else
#    define EXTERN_INLINE extern inline __attribute__((gnu_inline))
#  endif
#else
#  if defined(KEEP_INLINES)
#    define EXTERN_INLINE
#  else
#    define EXTERN_INLINE INLINE_HEADER
#  endif
#endif

on the grounds that the !__GNUC_GNU_INLINE__ case is perfectly safe to use, except that it might end up duplicating a little code. This will be safe even if Apple changes their mind in the future. Could someone try this version?

validates fine here.

thanks,
d~

_______________________________________________
Cvs-ghc mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/cvs-ghc

Reply via email to