Hello, I've had a look into these.
On Thu, Jan 29, 2009 at 15:20, José Pedro Magalhães <[email protected]> wrote: > Hello, > > On Wed, Jan 28, 2009 at 10:26, Simon Marlow <[email protected]> wrote: > >> Ian Lynagh wrote: >> >>> Mon Jan 19 03:23:21 PST 2009 'Jose Pedro Magalhaes <[email protected]>' >>> * #2875: Correct SYB's representation of Char >>> >>> M ./compiler/utils/Serialized.hs +18 >>> >> >> We have various Generics-related test failures, possibly due to the above >> patch(es). Could someone take a look please? >> >> Unexpected failures: >> >> >> bits(normal,optc,hpc,optasm,profc,profasm,ghci,threaded1,threaded2,profthreaded) >> >> >> genUpTo(normal,optc,hpc,optasm,profc,profasm,ghci,threaded1,threaded2,profthreaded) >> ghcpkg02(normal) >> >> >> strings(normal,optc,hpc,optasm,profc,profasm,ghci,threaded1,threaded2,profthreaded) >> >> >> tree(normal,optc,hpc,optasm,profc,profasm,ghci,threaded1,threaded2,profthreaded) > > > bits is just pattern-matching on a constructor which no longer exists. > Replacing it with the new constructor solves the problem. > I meant genUpTo and not bits. I'm attaching a patch (genUpTo.patch) to update the test. > > > The other 3 seem to be related to > http://hackage.haskell.org/trac/ghc/ticket/2759. Apparently this caused > gread to fail to read Float and Double types. I'll look further into it. > Actually, strings and tree were related to #2759, but bits was also related to #2875. The problem with #2759 was that it caused readConstr to fail for Float and Double types, since reads was being used without being told what type to read. This was fixed by forcing the type to Double. I'm attaching amend2759.base.patch. #2875 caused showConstr (toConstr 'p') to return "'p'" instead of "p". This in turn makes bits return a different (larger) result (but deserializing after serializing is still the identity). However, I think this result is 'ok'. Does anyone disagree? Thanks, Pedro
genUpTo.patch
Description: Binary data
amend2759.base.patch
Description: Binary data
_______________________________________________ Cvs-ghc mailing list [email protected] http://www.haskell.org/mailman/listinfo/cvs-ghc
