On 12/04/2010, at 16:30, Matthias Kilian wrote: > On Mon, Apr 12, 2010 at 11:47:26AM +1000, Ben Lippmeier wrote: >> The trouble is that the boot scripts use GNU specific features. >> I was the one that changed it to bash because I was tired of the >> build breaking on Solaris. I think the original problem was that >> the Solaris version of 'test' doesn't support some of the flags >> being used, but I'm sure there are others. > > Thats probably this one: > > [ "libraries/stamp/$p" -ot $tarball ]
FWIW, Solaris sh supports test ... -ot ... but not [ ... -ot ... ]. >> Please don't change it back to sh unless you've also validated >> the change on at least OSX, Solaris, Windows and Linux as well >> as your own platform. > > And here we have that validation problem again. You can't expect > that everyone who sends patches has access to all those types of > operating systems. Nor can one expect all the GHC developers to > have access to other, more `exotic' systems. While that is true, we should certainly expect that patches which obviously affect cross-platform compatibility are validated on all supported platforms. This is not to bash Gabor's patch (asking people on cvs-ghc to validate a patch is the right thing to do if you don't have access to all systems), I'm just making a general point. Roman _______________________________________________ Cvs-ghc mailing list [email protected] http://www.haskell.org/mailman/listinfo/cvs-ghc
