On Sat, Apr 02, 2011 at 11:01:26AM +0100, Max Bolingbroke wrote:
>
> I'm getting a validate failure for HEAD:
>
> {{{
> libraries/binary/src/Data/Binary/Builder.hs:2:16:
> Warning: -fglasgow-exts is deprecated: Use individual extensions instead
>
> <no location info>:
> Failing due to -Werror.
> }}}
Ah, I understand what's going on now.
I don't see this because it's when compiling with the stage0 compiler,
and stage0 > 7.0.
The binary git repo is converted from a git mirror of the upstream darcs
repo, rather than from GHC's darcs repo, and upstream haven't applied
this patch:
Tue Nov 2 18:58:52 GMT 2010 Ian Lynagh <[email protected]>
* Avoid "-fglasgow-exts deprecated" warning
Lennart, Don, could you do so please? Easiest way is probably to pull
from
http://darcs.haskell.org/libraries/binary/
> Have we always enabled -Werror when compiling upstream code like this?
Yes, although we work around some problems in mk/validate-settings.mk
> It seems sensible for validate to insist that libraries without an
> upstream are warning-clean, but it is harder to ensure that libraries
> like "binary" that we try to just pull from are also warning-clean.
If we believe warning-free code => higher quality code, shouldn't we
also ask for higher quality code from the things we depend on?
Thanks
Ian
_______________________________________________
Cvs-ghc mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/cvs-ghc
