Repository : ssh://darcs.haskell.org//srv/darcs/testsuite

On branch  : ghc-7.4

http://hackage.haskell.org/trac/ghc/changeset/bb32c877ddb46c4d5ebca5949fd5ac14f5265f7f

>---------------------------------------------------------------

commit bb32c877ddb46c4d5ebca5949fd5ac14f5265f7f
Author: Simon Marlow <[email protected]>
Date:   Mon Jan 16 15:49:39 2012 +0000

    Skip conc036 entirely (see comments)

>---------------------------------------------------------------

 tests/concurrent/should_run/all.T |   23 +++++++++++++++--------
 1 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/tests/concurrent/should_run/all.T 
b/tests/concurrent/should_run/all.T
index 37d5bcd..26f42e8 100644
--- a/tests/concurrent/should_run/all.T
+++ b/tests/concurrent/should_run/all.T
@@ -152,14 +152,21 @@ test('conc034', compose(only_compiler_types(['ghc']),
 
 test('conc035', only_compiler_types(['ghc']), compile_and_run, [''])
 
-# Omit for GHCi: firstly GHCi doesn't have unsafe FFI calls, and secondly
-# the main thread cannot receive the deadlock exception because it can be
-# woken up by ^C.
-# Omit for threaded2: this test is really bogus and fails to do anything
-# sensible for more than one CPU.
-test('conc036', compose(skip_if_fast,
-                 compose(omit_ways(['ghci','threaded2']),
-                   only_compiler_types(['ghc']))), compile_and_run, [''])
+# conc036: now skipped entirely.  This test attempts to check that
+# unsafe foreign calls block other threads, but doing that reliably is
+# probably impossible.  The last straw was when it started failing on
+# Windows around 7.4.x.
+#
+# OLD comments about hacks we tried to make it work:
+#   Omit for GHCi: firstly GHCi doesn't have unsafe FFI calls, and secondly
+#   the main thread cannot receive the deadlock exception because it can be
+#   woken up by ^C.
+#   Omit for threaded2: this test is really bogus and fails to do anything
+#   sensible for more than one CPU.
+#
+test('conc036', skip, compile_and_run, [''])
+
+
 # Interrupting foreign calls only makes sense if we are threaded
 test('foreignInterruptible', composes([skip_if_fast,
                                       only_threaded_ways,



_______________________________________________
Cvs-ghc mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/cvs-ghc

Reply via email to