On 20/09/12 17:07, Ian Lynagh wrote:
On Thu, Sep 20, 2012 at 08:35:36AM -0700, Simon Marlow wrote:
diff --git a/compiler/cmm/CmmLayoutStack.hs b/compiler/cmm/CmmLayoutStack.hs
index 5505b92..b4ca273 100644
--- a/compiler/cmm/CmmLayoutStack.hs
+++ b/compiler/cmm/CmmLayoutStack.hs
@@ -5,6 +5,7 @@ module CmmLayoutStack (
import StgCmmUtils ( callerSaveVolatileRegs ) -- XXX
import StgCmmForeign ( saveThreadState, loadThreadState ) -- XXX
+import StgCmmLayout ( entryCode ) -- XXX
What do these XXXs mean? I guess that an abstraction is being broken by
using them? Would it make sense to add a comment saying why, and what
the solution might be?
Yes, it's a breakage of the layering. codeGen is supposed to depend on
cmm, not the other way around (but this is by no means the only
instance). I'll add a note to the codeGen cleanup wiki page, and a
comment in the code.
Cheers,
Simon
_______________________________________________
Cvs-ghc mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/cvs-ghc
