Author: leo
Date: Tue Jan 31 05:12:07 2006
New Revision: 11387
Modified:
trunk/CREDITS
trunk/lib/Parrot/Configure/Data.pm
trunk/t/configure/data.t
Log:
Return-Path: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
Received: from localhost (localhost [127.0.0.1])
by lux.leo.home (Postfix on linux 2.0.36 (i386)) with ESMTP id
6239E118025
for <[EMAIL PROTECTED]>; Tue, 31 Jan 2006 13:18:40 +0100 (MET)
Received: from toetsch.at [216.71.209.130]
by localhost with POP3 (fetchmail-6.2.0)
for [EMAIL PROTECTED] (single-drop); Tue, 31 Jan 2006 13:18:40 +0100
(MET)
Received: (from [EMAIL PROTECTED])
by powerbox.prohost.de (8.11.6/8.11.6) id k0VCGos22967
for [EMAIL PROTECTED]; Tue, 31 Jan 2006 13:16:50 +0100
Received: from lists.develooper.com (x6.develooper.com [63.251.223.186])
by powerbox.prohost.de (8.11.6/8.11.6) with SMTP id k0VCGnK22947
for <[EMAIL PROTECTED]>; Tue, 31 Jan 2006 13:16:49 +0100
Received: (qmail 12727 invoked by uid 514); 31 Jan 2006 12:16:45 -0000
Mailing-List: contact [EMAIL PROTECTED]; run by ezmlm
Precedence: bulk
List-Post: <mailto:[email protected]>
List-Help: <mailto:[EMAIL PROTECTED]>
List-Unsubscribe: <mailto:[EMAIL PROTECTED]>
List-Subscribe: <mailto:[EMAIL PROTECTED]>
List-Id: <perl6-internals.perl.org>
Delivered-To: mailing list [email protected]
Delivered-To: moderator for [email protected]
Received: (qmail 2469 invoked from network); 30 Jan 2006 23:50:39 -0000
Delivered-To: [email protected]
X-Spam-Status: No, hits=-4.4 required=8.0
tests=ALL_TRUSTED,BAYES_00
X-Spam-Check-By: la.mx.develooper.com
Received-SPF: pass (x1.develooper.com: domain of [EMAIL PROTECTED] designates
63.251.223.176 as permitted sender)
[perl #38260] [BUG][PATCH] Parrot::Config contains invalid info
I have a partial solution. There was a bug in
Parrot::Configure::Data->add which caused it to always include a
stringified copy of self for every usage of add. This leads to a
large number of garbage hashref strings with even larger numbers of
delimiter seperated delimiter strings.
This effects lib/Parrot/Configure/Data and t/configure/data.t
Courtesy of Norman Nunley <[EMAIL PROTECTED]>
Modified: trunk/CREDITS
==============================================================================
--- trunk/CREDITS (original)
+++ trunk/CREDITS Tue Jan 31 05:12:07 2006
@@ -463,3 +463,7 @@ E: [EMAIL PROTECTED]
D: Tcl language (partcl), website, various languages/ upkeep, misc.
N: Zach Lipton
+
+N: Norman Nunley
+D: Shaving a Ponie
+E: [EMAIL PROTECTED]
\ No newline at end of file
Modified: trunk/lib/Parrot/Configure/Data.pm
==============================================================================
--- trunk/lib/Parrot/Configure/Data.pm (original)
+++ trunk/lib/Parrot/Configure/Data.pm Tue Jan 31 05:12:07 2006
@@ -155,8 +155,9 @@ returns a L<Parrot::Configure::Data> obj
sub add
{
- my ($self, $delim) = @_;
-
+ my $self = shift;
+ my $delim = shift;
+
while (my ($key, $val) = splice @_, 0, 2) {
my ($old) = $self->{c}{$key};
if (defined $old) {
Modified: trunk/t/configure/data.t
==============================================================================
--- trunk/t/configure/data.t (original)
+++ trunk/t/configure/data.t Tue Jan 31 05:12:07 2006
@@ -173,7 +173,7 @@ can_ok('Parrot::Configure::Data', qw(
{
my $pcd = Parrot::Configure::Data->new;
- $pcd->set(
+ $pcd->add('',
'a' => 1,
'b' => 2,
'c' => 3,
